ASoC: SOF: i.MX: simplify Kconfig #3180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plbossart
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
lyakh and
ranj063
as code owners
dbaluta
reviewed
Sep 28, 2021
| @@ -40,12 +40,14 @@ config SND_SOC_SOF_ACPI_DEV | |||
| config SND_SOC_SOF_OF | |||
| tristate "SOF OF enumeration support" | |||
There was a problem hiding this comment.
@plbossart i think this code is more clear. On the other hand saying that snd-sof-of is a 'helper' doesn't make much sense in my understanding.
snd-sof-of is the starting point for the OF platform driver:
sound/soc/sof/sof-of-dev.c
/* DT driver definition */
static struct platform_driver snd_sof_of_driver = {
» .probe = sof_of_probe,
» .remove = sof_of_remove,
» .driver = {
» » .name = "sof-audio-of",
» » .pm = &sof_of_pm,
» » .of_match_table = sof_of_ids,
» },
};
module_platform_driver(snd_sof_of_driver);
There was a problem hiding this comment.
it's not a pure library indeed, but the point is that sof-of-dev is at the end of the 'select' clauses, it does not select anything on its own. Maybe 'common module' is a better wording.
dbaluta
previously approved these changes
Sep 28, 2021
Follow the Intel example and simplify the Kconfig a) start from the end-product for 'select' chains b) use 'depends on' to filter out configurations. c) use snd-sof-of as a common module without any 'select' Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
force-pushed
the
fix/imx-makefiles
branch
from
ab2da3c
to
7122edc
Compare
dbaluta
approved these changes
Sep 28, 2021
iuliana-prodan
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the Intel example and simplify the Kconfig
a) start from the end-product and use snd-sof-of as a helper
b) use 'depends on' to filter out configurations.
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com