New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of validation errors #104
Comments
I agree with Romain. The internal representation is expanded from the json representation and specified in the spec for the benefit of interoperability, but it is the json representation which is validated via a json schema. |
Not for all values. If something is invalid, or not specified, and there is a default, that default may get swapped in. But if a date, for example, doesn't exactly match the ISO spec format, you can't replace it with anything. Is it worth completely tossing the property just for that reason? But given the nature of our manifest, most data is harmless, so I personally don't care if we drop the statement. It might look stupid presented to a user, but their browser won't burst into flames. |
Yes, IMO. |
Wow, you're harsh... ;) But I suppose in a sense that's fine, too. If we're going to be reasonably strict about metadata in the core being for processing/user configurability, then we probably need to be less lenient about invalid data. I don't really have a strong opinion one way or the other, though, to be honest. |
fix some links referencing the wrong infra definitions; fix some phrasing to better reflect the infra spec
I updated #103 last night to ignore/remove properties with invalid values. |
The processing algorithm currently says:
I'm not sure what this means.
My expectation would be that the algorithm itself defines precisely (I think it does, to be double-checked) what term is created (or not) when a value causes a validation error. In which case we don't need the statement above?
Unless I'm missing something, I'd be in favor of just removing this statement.
The text was updated successfully, but these errors were encountered: