ci: script to auto-upload your test results #68
Conversation
maksimmasalski
force-pushed
the
upload_test_results
branch
from
163be34
to
17c24e2
Compare
maksimmasalski
force-pushed
the
upload_test_results
branch
from
69cb411
to
72be075
Compare
|
@xuhao8210 I'm making changes of the upstream script, please review it too and my resolved conversations. Seems that we should use default sanitycheck names like reel_board.xml and etc. |
maksimmasalski
force-pushed
the
upload_test_results
branch
2 times, most recently
from
a895b61
to
7dcb2d1
Compare
There was a problem hiding this comment.
@maksimmasalski One last comment, (to comply with good practices on zephyr main repo) please squash your commits before merge.
maksimmasalski
force-pushed
the
upload_test_results
branch
from
7dcb2d1
to
c7205b9
Compare
maksimmasalski
force-pushed
the
upload_test_results
branch
from
c7205b9
to
60012a0
Compare
maksimmasalski
force-pushed
the
upload_test_results
branch
from
60012a0
to
0b41af9
Compare
Python script to automatically upload your HW Daily Test Results to the Github test_results repo Signed-off-by: Maksim Masalski <maksim.masalski@intel.com>
maksimmasalski
force-pushed
the
upload_test_results
branch
from
0b41af9
to
6ac711a
Compare
| logging.info('Source directory file path %s', source_file_path) | ||
| git_file_path = os.path.join(git_dir_path, file_name) | ||
| logging.info('Destination path to file to commit %s', git_file_path) | ||
| shutil.copy(source_file_path, git_file_path) |
There was a problem hiding this comment.
An error will be raised here while the file already exists. For example, we both run sanitycheck with iotdk, so you may have already uploaded iotdk.xml when I try to upload it.
There was a problem hiding this comment.
@wangnuannuan Yes, it will. I can add exception, but that question we can raise during TG Meeting today. Because, we except each company will upload results of their boards, and nobody can duplicate its test results. For example, your company is responsible for iotdk, and your must check results and provide only results for iotdk. No any other developer or company can upload iotdk results and duplicate them. Please, don't forget to raise that question during TW Meeting.
There was a problem hiding this comment.
@nashif Do you have any input about that? Each company uploads separate boards, right?
|
@nashif Do we plan to merge it? |
maksimmasalski
dismissed stale reviews from nashif and erwango
Already made changes
| logging.info('Push new repo updates to the origin ...') | ||
| origin.git.push(origin_name, 'master') | ||
| else: | ||
| logging.info("Repository already created, let's update master...") |
There was a problem hiding this comment.
what if the given directory is not a git repo? Maybe an error telling this? I think it is better to change the workflow, that first it checks if the directory exists (if not create dir), then if it is git repo and if not, initialize?
There was a problem hiding this comment.
Yes, we can add it, or add note in a Readme file.
According to out Testing WG discussion we will use manual uploading once per week. That will make our results more stable and without any additional garbage that can appear, if results will be uploaded automatically. |
Disentangle origin from upstream repos and update repo calls. Use pull --rebase for updating (regular pull does merge which can cause history conflicts) Signed-off-by: Maciej Perkowski <Maciej.Perkowski@nordicsemi.no>
Python script to automatically upload your HW Daily Test Results
to the Github test_results repo
Signed-off-by: Maksim Masalski maksim.masalski@intel.com