Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add t1_test to kernel cases #51288

Closed

Conversation

hakehuang
Copy link
Collaborator

according to #51286 we need tag the t1 cases as t1_test

cases with explicit arch/platfrom requirement are excluded cases with platform_allow are excluded

Signed-off-by: Hake Huang hake.huang@oss.nxp.com

according to zephyrproject-rtos#51286 we need tag the t1 cases as t1_test

cases with explicit arch/platfrom requirement are excluded
cases with platform_allow are excluded

Signed-off-by: Hake Huang <hake.huang@oss.nxp.com>
@andyross
Copy link
Contributor

Nitpickery from someone who tends to be allergic to project bureaucracy:

I'm... not sure I completely get what's happening here? Clicking through the links provided, I see "Tier 1" defined on page 8 of @nashif's slides as a hardware category. What does a "tier 1 test" mean, exactly? I'm guessing these are "The Tests We Expect Tier 1 Hardware To Pass"? Can we be explicit about that in the commit message or somewhere in the doc/ tree? Because I guarantee that people like me will come along and add tests and have no idea what "t1_test" means or whether they should copy it cargo-cult style into their new YAML files.

Maybe renaming this to "t1_mustpass" or "t1hw_requirement" might help?

No -1, just pointing out that the conventions here are getting thick.

Copy link
Member

@nashif nashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be documented first or some documation describing the purpose of this needs to be in place. What exactly is the requirement for a test to be tagged as t1_test? additionally, we should not use cryptic names or even use tags for this. A set of tests will be used to test T1 boards, does not mean we have to call this t1_test. I would find another genric name, ie.. Hardware Acceptance Test Plan or whatever that is used for T1 boards tests but also for anyone who want to bring in a board into zephyr and verify that it works, without having to be Tier 1.

@hakehuang
Copy link
Collaborator Author

This needs to be documented first or some documation describing the purpose of this needs to be in place. What exactly is the requirement for a test to be tagged as t1_test? additionally, we should not use cryptic names or even use tags for this. A set of tests will be used to test T1 boards, does not mean we have to call this t1_test. I would find another genric name, ie.. Hardware Acceptance Test Plan or whatever that is used for T1 boards tests but also for anyone who want to bring in a board into zephyr and verify that it works, without having to be Tier 1.

@nashif we have been discussion the list of test suite in test working group for some time. and the discussion is listed in the #51286 . During discussion, we find that helps for kernel expecters are needed to review the kernel cases for general test purpose. This PR is to list the cases to be selected, and we need some kernel expert to review the readiness of all kernel cases. and this list can be convert to a test plan after reviewing. and we can start to define a name for this list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants